Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Restore browsable API JSON indentation #20486

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

webjunkie
Copy link
Contributor

Problem

JSON rendering got updated in #20302 with no indents (cause faster)

Changes

We can look at the context to see if we are in the browsable API render.

How did you test this code?

Copy link

sentry-io bot commented Feb 21, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/renderers.py

Function Unhandled Issue
render TypeError: str is not valid UTF-8: surrogates not allowed /api/projects/{parent_lookup_team_id}/session_recordings/{pk}/s...
Event Count: 19

Did you find this useful? React with a 👍 or 👎

@webjunkie webjunkie requested review from a team and neilkakkar February 21, 2024 12:26
@webjunkie webjunkie merged commit c3d1c3a into master Feb 22, 2024
73 checks passed
@webjunkie webjunkie deleted the fix/browsable-api-render branch February 22, 2024 08:01
Copy link

sentry-io bot commented Feb 22, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Integer exceeds 64-bit range /api/projects/{parent_lookup_team_id}/persons/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants