fix: only get org invites if an org exists #20376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +33 B (0%) Total Size: 2.23 MB ℹ️ View Unchanged
|
xrdt
approved these changes
Feb 16, 2024
|
This seems to have fixed it! |
thmsobrmlr
pushed a commit
that referenced
this pull request
Feb 20, 2024
only get org invites if an org exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Any time you go to the signup page there is this error:
I'm not entirely sure why this is happening, I can't reproduce it locally. It seems like this logic should never be mounting if someone is unauth'd, but it is being mounted somewhere, and thus it's trying to load invites.
Changes
Only get org invites if an org exists. Seems like a possible solution? I have no idea if it works because I can't reproduce locally..
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?