Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hogql): trends funnel #20370

Merged
merged 19 commits into from
Feb 19, 2024
Merged

feat(hogql): trends funnel #20370

merged 19 commits into from
Feb 19, 2024

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Feb 15, 2024 •
edited
Loading

Problem

Funnels need to be converted to HogQL (see the funnels section in PostHog/meta#130).

Changes

  • Adds support for trends funnels.

How did you test this code?

Converted existing tests for the HogQL implementation

@thmsobrmlr thmsobrmlr mentioned this pull request Feb 15, 2024
Open
48 tasks
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 2.23 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.23 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 2 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr marked this pull request as ready for review February 15, 2024 18:18
@thmsobrmlr thmsobrmlr requested a review from a team February 15, 2024 18:19
mariusandra
mariusandra approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Base automatically changed from funnel-time-to-convert to master February 19, 2024 08:58
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) February 19, 2024 09:00
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

35 snapshot changes in total. 0 added, 35 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr
Merge branch 'master' into funnel-trends
8037c03 
# Conflicts:
#	frontend/__snapshots__/scenes-app-insights-error-empty-states--server-error--dark.png
#	frontend/__snapshots__/scenes-app-insights-error-empty-states--server-error--light.png
#	frontend/__snapshots__/scenes-app-persons-groups--persons--light.png
#	frontend/__snapshots__/scenes-app-pipeline--pipeline-landing-page--light.png
#	frontend/__snapshots__/scenes-app-pipeline--pipeline-node-configuration--light.png
#	frontend/__snapshots__/scenes-app-pipeline--pipeline-node-metrics--light.png
#	frontend/__snapshots__/scenes-other-settings--settings-organization--light.png
#	frontend/__snapshots__/scenes-other-settings--settings-project--light.png
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr merged commit c6e7bce into master Feb 19, 2024
73 of 78 checks passed
@thmsobrmlr thmsobrmlr deleted the funnel-trends branch February 19, 2024 10:54
thmsobrmlr added a commit that referenced this pull request Feb 20, 2024
@thmsobrmlr
feat(hogql): trends funnel (#20370)
65e1bb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thmsobrmlr @posthog-bot @mariusandra