Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): survey results viz fixes #20345

Merged
merged 15 commits into from
Feb 15, 2024
Merged

fix(surveys): survey results viz fixes #20345

merged 15 commits into from
Feb 15, 2024

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Feb 14, 2024

Problem

  • multiple choice bar would be set to a default height causing squished answers
  • make it easier for users to explore survey results data

Changes

before:
Screenshot 2024-02-14 at 11 26 22 AM
after:
Screenshot 2024-02-13 at 8 09 04 PM

Screen.Recording.2024-02-14.at.11.25.25.AM.mov

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link
Contributor

github-actions bot commented Feb 14, 2024

Size Change: 0 B

Total Size: 2.22 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.22 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@liyiy liyiy enabled auto-merge (squash) February 14, 2024 18:41
@liyiy liyiy disabled auto-merge February 14, 2024 18:46
@jurajmajerik
Copy link
Contributor

jurajmajerik commented Feb 15, 2024

The button is too wide:

image

With primary buttons, we often use button icons:
image
I think the barchart icon or something similar would suit well here.

Cool functionality btw :)

@liyiy
Copy link
Contributor Author

liyiy commented Feb 15, 2024

The button is too wide:

image With primary buttons, we often use button icons: image I think the `barchart` icon or something similar would suit well here.

Cool functionality btw :)

hmmm there's nothing in between 30 and 40 though (and 30 width makes it super squished) but looks like the icon makes it more balanced now, so sticking with 40

Screenshot 2024-02-15 at 1 03 09 PM

@liyiy liyiy enabled auto-merge (squash) February 15, 2024 18:05
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@liyiy liyiy merged commit 5951ec3 into master Feb 15, 2024
79 checks passed
@liyiy liyiy deleted the surveys-results-updates branch February 15, 2024 18:20
@jurajmajerik
Copy link
Contributor

Is it necessary to wrap the button in a div and use the max-w property? The button should scale automatically based on the content width 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants