fix: CORS requests when Origin is invalid or null #20343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankh
force-pushed
the
frank/cors-origin-null
branch
from
c1241d7 to
c322602
Compare
frankh
changed the title
frankh
force-pushed
the
frank/cors-origin-null
branch
from
c322602 to
59bb8dc
Compare
tiina303
approved these changes
Feb 15, 2024
In some situations (such as calling posthog from within an iframe) the Origin header can be "null" or otherwise invalid In these situations we can't echo back the requested origin so we need to send * instead
frankh
force-pushed
the
frank/cors-origin-null
branch
from
59bb8dc to
cf203b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In some situations (such as calling posthog from within an iframe) the Origin header can be "null" or otherwise invalid
In these situations we can't echo back the requested origin so we need to send * instead
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?