-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(persons-on-events): Add ClickHouse table for tracking distinct ID overrides (without Kafka ingestion) #20326
Conversation
…D overrides (without Kafka ingestion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I know we talked about some nullable is_deleted
but you are pulling in from the existing PERSON_DISTINCT_ID2_TABLE_BASE_SQL
I assume this makes things easier.
🚢 it
2835ad8
to
9190bfa
Compare
Ah yeah, that was around using a nullable |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Size Change: 0 B Total Size: 2.22 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Problem
This splits the
MergeTree
table out of #19855 to unblock progress on squash refactoring and backfill development against real schemas without worrying about juggling unmerged development branches.This doesn't include the Kafka engine and materialized view from #19855. I'd expect those tables to remain the same as they were implemented in that PR, but we don't want to actually start ingesting events until #20162 and #20226 have been merged to ensure that the overrides table only has data that is unaffected by the distinct ID reuse issues described in #20187.
More context on distinct ID overrides more broadly is here: https://github.com/PostHog/product-internal/pull/557
How did you test this code?