Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): time to convert funnel #20259

Merged
merged 11 commits into from
Feb 19, 2024
Merged

feat(hogql): time to convert funnel #20259

merged 11 commits into from
Feb 19, 2024

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Feb 12, 2024

Problem

Funnels need to be converted to HogQL (see the funnels section in PostHog/meta#130).

Changes

  • Adds support for time-to-convert funnels, thereby also.
  • Adds hogql support for "least" and "greatest" functions.
  • Explicitly types funnel results.

Things that aren't as nice as they could be

  • The clickhouse query explodes, as aliased tables get inlined (see snapshots).
  • The query was refactored to use a JOIN ON ... instead of a JOIN USING ..., as HogQL doesn't support USING yet and I wanted to get this over the line.

How did you test this code?

Converted existing tests for the HogQL implementation

Copy link
Contributor

github-actions bot commented Feb 12, 2024

Size Change: +221 B (0%)

Total Size: 2.22 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 2.22 MB +221 B (0%)

compressed-size-action

@thmsobrmlr thmsobrmlr mentioned this pull request Feb 12, 2024
48 tasks
thmsobrmlr and others added 3 commits February 14, 2024 13:54
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 0 modified, 0 deleted
  • webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr marked this pull request as ready for review February 14, 2024 17:44
@thmsobrmlr thmsobrmlr requested a review from a team February 14, 2024 17:44
@thmsobrmlr thmsobrmlr merged commit e78c4e3 into master Feb 19, 2024
81 checks passed
@thmsobrmlr thmsobrmlr deleted the funnel-time-to-convert branch February 19, 2024 08:58
thmsobrmlr added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants