feat: Tighter modals #20238
Merged
feat: Tighter modals #20238
+123
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated62 snapshot changes in total. 0 added, 62 modified, 0 deleted:
Triggered by this commit. |
daibhin
approved these changes
Feb 9, 2024
frontend/__snapshots__/components-subscriptions--subscriptions--light.png
Show resolved
Hide resolved
|
Size Change: +52 B (0%) Total Size: 2.22 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated10 snapshot changes in total. 0 added, 10 modified, 0 deleted:
Triggered by this commit. |
Twixes
approved these changes
Feb 12, 2024
| @@ -176,6 +176,7 @@ $_lifecycle_dormant: $_danger; | |||
| --radius: 0.375rem; | |||
| --radius-sm: 0.25rem; | |||
| --shadow-elevation: 0px 16px 16px -16px rgb(0 0 0 / 35%); | |||
| --modal-shadow-elevation: 0px 16px 16px -16px rgb(0 0 0 / 35%); | |||
There was a problem hiding this comment.
I feel like for modals we should be using the same shadow as for other floating stuff, i.e. popovers/dropdowns. I agree the current shadow does not necessary convey that the element is floating above other content, since it looks button-like. @corywatilo You recently mentioned improving dropdowns, maybe you have some opinions on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Modals padding always felt off to me and in 3000 its even more off.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?