feat: Move onboarding into the app #20224

xrdt · 2024-02-08T19:57:28Z

Problem

Changes

Screen.Recording.2024-02-08.at.12.34.17.PM.mp4

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

posthog-bot · 2024-02-08T19:57:39Z

Hey @xrdt! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

posthog-bot · 2024-02-08T20:07:31Z

📸 UI snapshots have been updated

76 snapshot changes in total. 0 added, 76 modified, 0 deleted:

chromium: 0 added, 76 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

xrdt · 2024-02-08T20:38:34Z

Remaining things:

~~How to do update the state so people are by default navigated to the step after Install if it the product they select isn't the first they're onboarding to.~~
- ~~There's an issue here with when the onboardingSteps get updated from [] on the intro page to whatever they actually are when navigate to the onboarding scene.~~
~~Allow people to toggle the plans comparison and selector open even after they've subscribed.~~
~~Show the upgrade without add ons button.~~

posthog-bot · 2024-02-08T20:56:35Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-09T02:38:48Z

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

chromium: 0 added, 5 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

xrdt · 2024-02-09T22:55:56Z

@raquelmsmith addressed your comments about making the intro page an actual onboarding step, updated when we fire the onboarding product selected event so it doesn't fire on intro page visits, and moved verification into the sdk / install page.

frontend/__snapshots__/posthog-3000-navigation--navigation-base--dark.png

posthog-bot · 2024-02-09T23:28:05Z

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

chromium: 0 added, 6 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

* Only report onboarding product selected when "get started button clicked" * Don't show intro if coming from /products page

github-actions · 2024-02-12T19:57:57Z

Size Change: +12 kB (+1%)

Total Size: 2.23 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	2.23 MB	+12 kB (+1%)

_{compressed-size-action}

posthog-bot · 2024-02-14T17:30:57Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

This reverts commit c2fb465.

This reverts commit 613b5a1.

posthog-bot · 2024-02-14T21:48:14Z

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

chromium: 0 added, 6 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

frontend/src/scenes/billing/PlanComparison.scss

frontend/__snapshots__/scenes-other-onboarding--onboarding-sd-ks--light.png

frontend/__snapshots__/scenes-other-products--products--light.png

frontend/src/scenes/billing/PlanComparison.tsx

frontend/src/scenes/onboarding/onboardingLogic.tsx

frontend/src/scenes/onboarding/OnboardingBillingStep.tsx

frontend/src/scenes/onboarding/onboardingLogic.tsx

Co-authored-by: Raquel Smith <[email protected]>

posthog-bot · 2024-02-15T00:42:50Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

* add back subscribe buttons on billing page * rename a selector

posthog-bot · 2024-02-15T01:23:32Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-15T01:35:59Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-15T18:52:22Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-15T19:02:50Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-02-15T19:11:57Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 0 modified, 0 deleted
webkit: 0 added, 1 modified, 0 deleted (diff for shard 2)

Triggered by this commit.

👉 Review this PR's diff of snapshots.

xrdt requested a review from raquelmsmith February 8, 2024 20:38

xrdt force-pushed the by/onboarding-in-app branch from fd7d738 to 27725b6 Compare February 8, 2024 20:40

xrdt commented Feb 9, 2024

View reviewed changes

frontend/__snapshots__/posthog-3000-navigation--navigation-base--dark.png Outdated Show resolved Hide resolved

Bianca Yang and others added 18 commits February 12, 2024 11:46

bring onboarding panels into the app

39bb8f4

tune up product intro page breadcrumbs

997fed2

combine verification and config steps

a5fd176

add breadcrumbs, tune up topbar breadcrumbs

c32ba42

tune up some buttons, step order

af9e8dd

mostly update the plans page

18cce74

Update UI snapshots for chromium (1)

7b9ac96

Update UI snapshots for chromium (2)

3c4b26f

tune up state for not first product onboarding

4a9f3f5

Update UI snapshots for chromium (2)

a898296

some type fixes

8f7b98a

fix up remaining tasks

e693dad

Update UI snapshots for chromium (1)

9f04994

make product intro onboarding step

5929dee

* Only report onboarding product selected when "get started button clicked" * Don't show intro if coming from /products page

show verification on install screen

f8ce3e7

fix a type error, update intro in stories

02bb55e

Update UI snapshots for chromium (1)

d70a43e

fix a type generation issue

7df12c8

xrdt force-pushed the by/onboarding-in-app branch from 966c4fe to 7df12c8 Compare February 12, 2024 19:48

Bianca Yang and others added 2 commits February 14, 2024 09:21

Merge remote-tracking branch 'origin/master' into by/onboarding-in-app

895e060

Update UI snapshots for webkit (2)

fc431fd

Bianca Yang and others added 4 commits February 14, 2024 13:38

fix some onboarding snapshots

6f3abb4

Revert "Update UI snapshots for chromium (2)"

d9760af

This reverts commit c2fb465.

Revert "Update UI snapshots for chromium (1)"

5aad7ca

This reverts commit 613b5a1.

Update UI snapshots for chromium (1)

c422e90

raquelmsmith reviewed Feb 14, 2024

View reviewed changes

raquelmsmith approved these changes Feb 14, 2024

View reviewed changes

xrdt and others added 2 commits February 14, 2024 16:33

Update frontend/src/scenes/onboarding/OnboardingBillingStep.tsx

bdf3868

Co-authored-by: Raquel Smith <[email protected]>

Update UI snapshots for webkit (2)

d39216a

Bianca Yang and others added 3 commits February 14, 2024 16:57

wip

9bdccae

address pr comments

fb407d4

* add back subscribe buttons on billing page * rename a selector

Update UI snapshots for chromium (1)

baaf23e

Update UI snapshots for webkit (2)

09bb9f6

Bianca Yang and others added 4 commits February 15, 2024 10:42

small change to upgrade button

beea51e

remove extraneous files

6e22e3d

Merge remote-tracking branch 'origin/master' into by/onboarding-in-app

81b901c

Update UI snapshots for webkit (2)

0e2065b

Update UI snapshots for webkit (2)

f806174

Update UI snapshots for webkit (2)

7308e4d

xrdt merged commit 2fb1358 into master Feb 15, 2024
79 checks passed

xrdt deleted the by/onboarding-in-app branch February 15, 2024 19:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Move onboarding into the app #20224

feat: Move onboarding into the app #20224

xrdt commented Feb 8, 2024 •

edited

Loading

posthog-bot commented Feb 8, 2024

posthog-bot commented Feb 8, 2024

xrdt commented Feb 8, 2024 •

edited

Loading

posthog-bot commented Feb 8, 2024

posthog-bot commented Feb 9, 2024

xrdt commented Feb 9, 2024

posthog-bot commented Feb 9, 2024

github-actions bot commented Feb 12, 2024 •

edited

Loading

posthog-bot commented Feb 14, 2024

posthog-bot commented Feb 14, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

posthog-bot commented Feb 15, 2024

feat: Move onboarding into the app #20224

feat: Move onboarding into the app #20224

Conversation

xrdt commented Feb 8, 2024 • edited Loading

Problem

Changes

How did you test this code?

posthog-bot commented Feb 8, 2024

posthog-bot commented Feb 8, 2024

📸 UI snapshots have been updated

xrdt commented Feb 8, 2024 • edited Loading

posthog-bot commented Feb 8, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 9, 2024

📸 UI snapshots have been updated

xrdt commented Feb 9, 2024

posthog-bot commented Feb 9, 2024

📸 UI snapshots have been updated

github-actions bot commented Feb 12, 2024 • edited Loading

posthog-bot commented Feb 14, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 14, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

posthog-bot commented Feb 15, 2024

📸 UI snapshots have been updated

xrdt commented Feb 8, 2024 •

edited

Loading

xrdt commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading