feat(hogql): unordered funnel #20213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
funnel-unordered
branch
2 times, most recently
from
336620f to
f6174a2
Compare
thmsobrmlr
force-pushed
the
funnel-unordered
branch
from
f6174a2 to
fc1d1d2
Compare
|
Failing test is failing in master as well - please merge if you have the necessary rights. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Funnels need to be converted to HogQL (see the funnels section in PostHog/meta#130).
Changes
This PR adds the unordered funnel and associated tests. Breakdown tests have been commented out, as they are dependent on #20153, which im procrastinating from.
How did you test this code?
Converted existing tests for the HogQL implementation