Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): strict order funnel #20211

Merged
merged 6 commits into from
Feb 9, 2024
Merged

feat(hogql): strict order funnel #20211

merged 6 commits into from
Feb 9, 2024

Conversation

thmsobrmlr
Copy link
Contributor

Problem

Funnels need to be converted to HogQL (see the funnels section in PostHog/meta#130).

Changes

This PR adds the strictly ordered funnel and associated tests. Breakdown tests have been commented out, as they are dependent on #20153, which im procrastinating from.

How did you test this code?

Converted existing tests for the HogQL implementation

@thmsobrmlr thmsobrmlr mentioned this pull request Feb 8, 2024
48 tasks
@thmsobrmlr thmsobrmlr requested a review from a team February 8, 2024 17:40
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@thmsobrmlr thmsobrmlr merged commit 365ba4f into master Feb 9, 2024
72 checks passed
@thmsobrmlr thmsobrmlr deleted the funnel-strict branch February 9, 2024 09:01
Gilbert09 pushed a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants