fix(experiments): add exposure column when variants > 4 #20140
Conversation
|
Size Change: 0 B Total Size: 2.22 MB ℹ️ View Unchanged
|
| @@ -67,6 +67,14 @@ export function ExperimentResult(): JSX.Element { | |||
| </Col> | |||
| ))} | |||
| </div> | |||
| <div className="flex justify-between py-2 border-t"> | |||
There was a problem hiding this comment.
small nit for Line 60: Can you update it to say metric when appropriate as well, like here: https://github.com/PostHog/posthog/blob/master/frontend/src/scenes/experiments/ExperimentResult.tsx#L107
There was a problem hiding this comment.
eh, I'm not sure I understand, can you double check? 👇 (assuming you meant line 70)
b016655#diff-ed1b2dce372049018efc84c25054c92c9b1f2b8f4b374314e2475fae436f67a9R71-R73
There was a problem hiding this comment.
Sorry for not being clear, I meant line 60. Just calling it Exposure here is fine, but when using experiment goals like 'avg per user', calling the number as "count" doesn't make sense. We do this right for < 4 variants, but it still says "Count" always for > 4 variants
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
@Twixes do you know why the snapshot wouldn't show the full page / is there an option to snapshot the whole page?
There was a problem hiding this comment.
Hm, should show the whole page. Will look into it
…experiments-exposure-column
…PostHog/posthog into fix/experiments-exposure-column
Changes
Add the exposure column for when the variants count > 4
How did you test this code?
👀