Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bi): Fixed resizing of data viz tiles and some css fixes for BI #20139

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

Gilbert09
Copy link
Member

Problem

  • Resizing data viz nodes on dashboards would cause scrollbars to appear and the underlying chart canvas wouldn't resize
  • The borderless prop of LemonTabs was removed, and so we were getting double borders in the data viz sidebar

Changes

  • Fixed resizing data viz charts
  • Fixed the double border in the data viz chart sidebar
  • Other small css fixes to make the editor a bit nicer
Screen.Recording.2024-02-05.at.15.43.33.mov
image

How did you test this code?

  • Manually in browser

@Gilbert09 Gilbert09 requested a review from a team February 5, 2024 15:48
@Gilbert09 Gilbert09 mentioned this pull request Feb 5, 2024
69 tasks
@Gilbert09 Gilbert09 enabled auto-merge (squash) February 5, 2024 15:56
Copy link
Contributor

github-actions bot commented Feb 5, 2024

Size Change: +2 B (0%)

Total Size: 2.22 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 2.22 MB +2 B (0%)

compressed-size-action

@Gilbert09 Gilbert09 merged commit 2fc91f2 into master Feb 5, 2024
80 checks passed
@Gilbert09 Gilbert09 deleted the tom/bi-resize-css branch February 5, 2024 16:02
@Gilbert09
Copy link
Member Author

Darn it, auto merge merges as soon as the checks pass, even without an approving review 🤦

@webjunkie
Copy link
Contributor

Darn it, auto merge merges as soon as the checks pass, even without an approving review 🤦

That's annoying me as well... we should block merges without review by default (have that admin checkbox to override).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants