Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow overflow on exporter dashboard #20028

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

MarconLP
Copy link
Member

Problem

#19993 broke scrolling on embedded dashboards, this PR fixes that.

example us cloud: https://us.posthog.com/embedded/PNA0ip9JmXwN2gGHdrEB8kGRkUMr8Q

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

tested it out in my browser

@MarconLP MarconLP requested a review from thmsobrmlr January 30, 2024 09:39
@MarconLP MarconLP changed the title allow overflow on exporter dashboard fix: allow overflow on exporter dashboard Jan 30, 2024
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

Copy link
Contributor

Size Change: 0 B

Total Size: 2.22 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.22 MB

compressed-size-action

@thmsobrmlr thmsobrmlr merged commit ae56018 into master Jan 30, 2024
79 checks passed
@thmsobrmlr thmsobrmlr deleted the fix-embed-scrolling branch January 30, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants