Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(queries): capture parse errors #19987

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Conversation

thmsobrmlr
Copy link
Contributor

Problem

Some queries aren't running due to parse errors, but we have no introspection into these.

Changes

This PR captures parse errors in Sentry.

How did you test this code?

n/a

@thmsobrmlr thmsobrmlr requested a review from a team January 26, 2024 15:02
Copy link
Contributor

@webjunkie webjunkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it can be useful for now.

But in general I think the reasoning here is that you don't capture these as they are on the same level as other "bad requests" as opposed to "oops our application is not working as intended".

@thmsobrmlr
Copy link
Contributor Author

But in general I think the reasoning here is that you don't capture these as they are on the same level as other "bad requests" as opposed to "oops our application is not working as intended".

Makes sense. Let's remove this once we've fully transitioned from filters to queries again.

@thmsobrmlr thmsobrmlr merged commit 859b2bd into master Jan 26, 2024
73 checks passed
@thmsobrmlr thmsobrmlr deleted the capture-parse-errors branch January 26, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants