Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade OpenAI client #19986

Merged
merged 12 commits into from
Jan 29, 2024
Merged

chore: upgrade OpenAI client #19986

merged 12 commits into from
Jan 29, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Jan 26, 2024

Problem

We're using a pre v1 version of the OpenAI package. All their docs referenced methods / classes we did not have

Changes

How did you test this code?

Made sure AI summaries still generated for session recordings & SQL generator still gave a reply

@daibhin daibhin requested review from pauldambra and Twixes January 26, 2024 14:38
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like mypy is unhappy about something...

assuming you resolve that, I'll assume the summaries still run and so 🚢

Copy link
Contributor

github-actions bot commented Jan 26, 2024

Size Change: 0 B

Total Size: 2.22 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.22 MB

compressed-size-action

@daibhin daibhin merged commit 974553f into master Jan 29, 2024
79 checks passed
@daibhin daibhin deleted the dn-chore/upgrade-openai branch January 29, 2024 11:47
xrdt pushed a commit that referenced this pull request Jan 30, 2024
thmsobrmlr pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants