Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unify what's new to go to the changelog #19985

Merged
merged 6 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed frontend/public/3000/3000-command-palette-dark.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-command-palette.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-dark-mode.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-launch.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-nav-dark.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-nav.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-notebooks-dark.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-notebooks.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-search-dark.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-search.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-side-panel-dark.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-side-panel.png
Binary file not shown.
Binary file removed frontend/public/3000/3000-toolbar.png
Binary file not shown.
2 changes: 2 additions & 0 deletions frontend/src/layout/navigation-3000/navigationLogic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
props({} as { inputElement?: HTMLInputElement | null }),
connect(() => ({
values: [sceneLogic, ['sceneConfig'], navigationLogic, ['mobileLayout'], teamLogic, ['currentTeam']],
actions: [navigationLogic, ['closeAccountPopover']],
})),
actions({
hideSidebar: true,
Expand Down Expand Up @@ -133,6 +134,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
{
showNavOnMobile: () => true,
hideNavOnMobile: () => false,
closeAccountPopover: () => false,
},
],
isSidebarKeyboardShortcutAcknowledged: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ export const SidePanelDocs: StoryFn = () => {
return <BaseTemplate panel={SidePanelTab.Docs} />
}

export const SidePanelWelcome: StoryFn = () => {
return <BaseTemplate panel={SidePanelTab.Welcome} />
}

export const SidePanelSettings: StoryFn = () => {
return <BaseTemplate panel={SidePanelTab.Settings} />
}
Expand Down
8 changes: 1 addition & 7 deletions frontend/src/layout/navigation-3000/sidepanel/SidePanel.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import './SidePanel.scss'

import { IconConfetti, IconEllipsis, IconFeatures, IconGear, IconInfo, IconNotebook, IconSupport } from '@posthog/icons'
import { IconEllipsis, IconFeatures, IconGear, IconInfo, IconNotebook, IconSupport } from '@posthog/icons'
import { LemonButton, LemonMenu, LemonMenuItems } from '@posthog/lemon-ui'
import clsx from 'clsx'
import { useActions, useValues } from 'kea'
Expand All @@ -19,7 +19,6 @@ import { SidePanelFeaturePreviews } from './panels/SidePanelFeaturePreviews'
import { SidePanelSettings } from './panels/SidePanelSettings'
import { SidePanelStatus, SidePanelStatusIcon } from './panels/SidePanelStatus'
import { SidePanelSupport } from './panels/SidePanelSupport'
import { SidePanelWelcome } from './panels/SidePanelWelcome'
import { sidePanelLogic } from './sidePanelLogic'
import { sidePanelStateLogic } from './sidePanelStateLogic'

Expand Down Expand Up @@ -67,11 +66,6 @@ export const SIDE_PANEL_TABS: Record<SidePanelTab, { label: string; Icon: any; C
Icon: SidePanelDiscussionIcon,
Content: SidePanelDiscussion,
},
[SidePanelTab.Welcome]: {
label: "What's new?",
Icon: IconConfetti,
Content: SidePanelWelcome,
},
[SidePanelTab.Status]: {
label: 'System status',
Icon: SidePanelStatusIcon,
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const sidePanelDocsLogic = kea<sidePanelDocsLogicType>([
path(['scenes', 'navigation', 'sidepanel', 'sidePanelDocsLogic']),
connect({
actions: [sidePanelStateLogic, ['openSidePanel', 'closeSidePanel']],
values: [sceneLogic, ['sceneConfig']],
values: [sceneLogic, ['sceneConfig'], sidePanelStateLogic, ['selectedTabOptions']],
}),

actions({
Expand Down Expand Up @@ -85,7 +85,13 @@ export const sidePanelDocsLogic = kea<sidePanelDocsLogicType>([
})),

afterMount(({ actions, values }) => {
if (values.sceneConfig?.defaultDocsPath) {
// If a destination was set in the options, use that
// otherwise the default for the current scene
// otherwise, whatever it last was set to
if (values.selectedTabOptions) {
const initialPath = getPathFromUrl(values.selectedTabOptions)
actions.setInitialPath(initialPath)
} else if (values.sceneConfig?.defaultDocsPath) {
actions.setInitialPath(values.sceneConfig?.defaultDocsPath)
}
}),
Expand Down
Loading
Loading