feat(insights): sanitize retention query

[mariusandra]

Problem

JSON parse error - 6 validation errors for QueryRequest
query.RetentionQuery.retentionFilter.returningEntity.math
Extra inputs are not permitted

Changes

Sanitizes the retention entity fields.

How did you test this code?

Nothing broke locally

[github-actions]

Size Change: 0 B

Total Size: 2.21 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	2.21 MB

_{compressed-size-action}

[Gilbert09]

If we were to add a new key to RetentionEntity, would we need to add it here too? May be worth a comment somewhere, otherwise we may get some confused devs in the future

[mariusandra]

Perhaps... but I hope we won't need this soon anymore. As soon as the filters object is gone, this will be as well.

The backend has a more sensible allow-list approach though

posthog/posthog/hogql_queries/legacy_compatibility/filter_to_query.py

Lines 145 to 151 in 4aa36d8

	return {
	"type": entity.get("type"),
	"id": entity.get("id"),
	"name": entity.get("name"),
	"custom_name": entity.get("custom_name"),
	"order": entity.get("order"),
	}

But since the tests are all green, I'll use the opportunity and merge it in. There will be more adjustments...