Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make PropertySelect component generic #19971

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Jan 25, 2024

Problem

Related to #19887

The PersonPropertySelect component cannot be used for Event property definitions

Changes

Abstract TaxonomicFilterGroupType as a prop

How did you test this code?

Via stories

Copy link
Contributor

Size Change: 0 B

Total Size: 2.21 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.21 MB

compressed-size-action

@daibhin daibhin requested a review from a team January 26, 2024 09:51
@daibhin daibhin merged commit 68ed024 into master Jan 26, 2024
79 checks passed
@daibhin daibhin deleted the dn-chore/make-property-select-generic branch January 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants