Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add eslint no-useless-rename rule #19966

Merged
merged 1 commit into from
Jan 26, 2024
Merged

chore: Add eslint no-useless-rename rule #19966

merged 1 commit into from
Jan 26, 2024

Conversation

webjunkie
Copy link
Contributor

Problem

Useless renames were allowed:

const {
    query: query,
    ...
}

Changes

  • turn on rule and auto fix

How did you test this code?

  • n/a

@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 2.21 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.21 MB

compressed-size-action

@webjunkie webjunkie requested a review from a team January 26, 2024 07:47
mariusandra
mariusandra approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not

@webjunkie webjunkie merged commit c2631c2 into master Jan 26, 2024
80 checks passed
@webjunkie webjunkie deleted the chore/eslint-useless-rename branch January 26, 2024 09:21
@webjunkie
Copy link
Contributor Author

That's the spirit!

daibhin pushed a commit that referenced this pull request Jan 26, 2024
@webjunkie @daibhin
chore: Add eslint no-useless-rename rule (#19966)
4e491fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webjunkie @mariusandra