chore: remove antd progress #19953
chore: remove antd progress #19953
Conversation
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
daibhin
force-pushed
the
dn-chore/remove-antd-progress
branch
from
709f9b7 to
adb8f7a
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
daibhin
force-pushed
the
dn-chore/remove-antd-progress
branch
from
261cef8 to
7804f37
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: 0 B Total Size: 2.22 MB ℹ️ View Unchanged
|
| .LemonProgress { | ||
| .LemonProgress__track { | ||
| transition: all 0.4s cubic-bezier(0.08, 0.82, 0.17, 1) 0s; | ||
| } | ||
| } |
There was a problem hiding this comment.
Is Tailwind transition not enough? Ideally we should avoid .scss
| strokeColor={ | ||
| trackColor={ |
There was a problem hiding this comment.
I do believe strokeColor better represented what this means, because the track is the gray underlying bar. I think strokeColor or rangeColor would be clearer here. (E.g. Radix UI calls these parts "track" and "range")
| <span | ||
| className={clsx( | ||
| 'LemonProgress__track block h-full rounded-full', | ||
| percent > 0 ? (size === 'large' ? 'min-w-5' : 'min-w-[0.375rem]') : null |
| className?: string | ||
| } | ||
|
|
||
| export const LemonProgress = ({ |
There was a problem hiding this comment.
Now that I think about this component, it would actually totally make sense to use it as the base of LemonSlider, just without the transition 🤔 I might do this in another PR
daibhin
force-pushed
the
dn-chore/remove-antd-progress
branch
from
6480e34 to
f2b7539
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
daibhin
force-pushed
the
dn-chore/remove-antd-progress
branch
from
aeb5d78 to
12a7cdc
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
Problem
Removing some old antd
ProgresscomponentsChanges
Replicate all functionality currently used
How did you test this code?
Checked each case