-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hogql): sequential steps funnel #19951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
commented
Jan 30, 2024
Size Change: +85 B (0%) Total Size: 2.22 MB ℹ️ View Unchanged
|
thmsobrmlr
changed the title
feat(hogql): funnel ordered steps
feat(hogql): sequential steps funnel
Feb 6, 2024
mariusandra
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's a lot of code. Reading through it all, it looks good, though obviously I didn't take the time to do a very deep review. Didn't spot anything odd either. Great work. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Funnels need to be converted to HogQL (see the funnels section in PostHog/meta#130).
Changes
This PR:
grep TODO -rn posthog/hogql_queries/insights/funnels
should be gone once the funnels rewrite is complete.Follow-ups
How did you test this code?
I adapted the test script here https://gist.github.com/thmsobrmlr/ece8131eb7272893c274b3d9e77fc65c. It runs on most of my local insights, except some with validation errors and in one insight the conversion times don't match (to be investigated).