feat(flags): Add distinct id and group key matching #19902
Conversation
|
Size Change: +244 B (0%) Total Size: 2 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Is it possible to merge metadataTaxonomicGroupToPropertyFilterType and optionsFromProp? So that you'd pass along something like:
const taxonomicOptions: TaxonomicFilterProps['optionsFromProp'] = {
[TaxonomicFilterGroupType.Metadata]: [{ name: 'distinct_id', return_type: PropertyFilterType.Person }],
}
This would make the metadata field much more meta, and avoid passing through one large and very specific key.
Or is that complicated somehow? 🤔
|
Slightly complicated, leads to a bigger refactor I'm not yet keen on, because propertyType is determined per taxonomicGroup, not specific selected items inside the group 🫠 -> https://github.com/PostHog/posthog/blob/metadata-flags/frontend/src/lib/components/PropertyFilters/components/taxonomicPropertyFilterLogic.ts#L92 |
|
... actually, doesn't seem too bad? Let me try it 👀 , would make things nicer for sure, and prevent the 'metadata needs to be single type' in future problem |
|
Ok, done, this is nice 🙌 |
| // :TRICKY: When we have a GroupNamesPrefix taxonomic filter, selecting the group name | ||
| // is the equivalent of selecting a property value | ||
| const property: AnyPropertyFilter = { | ||
| key: propertyKey.toString(), | ||
| value: null, | ||
| key: isGroupNameFilter ? '$group_key' : propertyKey.toString(), | ||
| value: isGroupNameFilter ? propertyKey.toString() : null, |
There was a problem hiding this comment.
This override is the last thing that raises eyebrows... Happy to let is pass though, the impact is very minimal.
The bigger UX sadness here, which can also be for later, is that once you select an organization, the filter says "Group key", not "Organization key".
The title there can probably be fixed/overridden easily, but up to you if you want to...
There was a problem hiding this comment.
Want to keep it is group_key for now, given it's in context of matching org(s), and this is the actual field when, say, calling $groupIdentify(). Will revisit though if this raises confusion
Problem
Split out from #19792 -> add group and distinct id targeting to flags
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
👀