chore: enable gossip for flower and to squelch errors #19823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The celery logs were filled with this error:
After doing a bit of research it turns out this is related to gossip and flower collecting stats on the workers. I turned this on in K8s and the errors went a way and Flower was happy.
Note: This does increase utilization on redis some, but it should be fine at our levels (only 24 workers max right now)
Note2: We are currently running with gossip enabled manually on prod, probably should be everywhere unless there is a reason not to. It is the default for our version of celery.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?