Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(product-analytics): lineGraphLogic.ts to tooltip-data.ts #19815

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Jan 17, 2024

Problem

While working on #19813, I noticed we have this createTooltipData util in lineGraphLogic… and that was actually the whole logic, just that util.

Changes

It's been a while since it's been that way, so I propose we get rid of the logic wrapper.

@Twixes Twixes requested a review from thmsobrmlr January 17, 2024 16:05
Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense.. Thanks for the cleanup!

@Twixes Twixes enabled auto-merge (squash) January 17, 2024 19:23
Copy link
Contributor

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@Twixes Twixes merged commit 2ad53ef into master Jan 17, 2024
99 checks passed
@Twixes Twixes deleted the refactor-line-graph-logic branch January 17, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants