Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query-nodes): camel case paths filter #19795

Merged
merged 11 commits into from
Jan 19, 2024
Merged

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Jan 16, 2024

Problem

We want to clean up our query schema. See also #19541.

Changes

This PR camel cases all pathFilter properties.

  •  edge_limit
  •  paths_hogql_expression
  •  include_event_types
  •  start_point
  •  end_point
  •  path_groupings
  •  exclude_events
  •  step_limit
  •  path_replacements
  •  local_path_cleaning_filters
  •  min_edge_weight
  •  max_edge_weight
  •  funnel_paths
  •  funnel_filter - the filters themselves aren't touched in any way. probably best to do so when we implement the hogql version of the query

How did you test this code?

Verified setting, saving and loading an insight with this filter works

@thmsobrmlr thmsobrmlr changed the title Camel case paths filter chore(query-nodes): camel case paths filter Jan 16, 2024
Copy link
Contributor

github-actions bot commented Jan 16, 2024

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@thmsobrmlr thmsobrmlr force-pushed the camel-case-paths-filter branch from f0d3a7a to 1e6b129 Compare January 17, 2024 16:16
@thmsobrmlr thmsobrmlr requested a review from a team January 17, 2024 16:35
@thmsobrmlr thmsobrmlr marked this pull request as ready for review January 17, 2024 16:35
Base automatically changed from camel-case-show-legend to master January 19, 2024 11:58
@thmsobrmlr thmsobrmlr force-pushed the camel-case-paths-filter branch from 1e6b129 to 73550ae Compare January 19, 2024 11:59
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) January 19, 2024 11:59
@thmsobrmlr thmsobrmlr merged commit 1a6e53d into master Jan 19, 2024
99 checks passed
@thmsobrmlr thmsobrmlr deleted the camel-case-paths-filter branch January 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants