Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(vrt): Don't clip scene snapshots #19677

Merged
merged 63 commits into from
Mar 18, 2024
Merged

test(vrt): Don't clip scene snapshots #19677

merged 63 commits into from
Mar 18, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Jan 9, 2024 •
edited
Loading

Problem

Scene snapshots were clipped. (https://github.com/PostHog/posthog/pull/20140/files/bb301081121d654a1793329e74d97de128fcacea#r1479626084)

Changes

They should not be clipped now.
Also fixed Scenes-App/Insights/Error & Empty States stories being flaky.

@Twixes Twixes force-pushed the scene-snapshots-noclip branch from 49690e3 to e688f7b Compare January 9, 2024 16:44
@Twixes Twixes reopened this Feb 13, 2024
@posthog-bot posthog-bot removed the stale label Feb 14, 2024
@Twixes Twixes reopened this Feb 28, 2024
@posthog-bot posthog-bot removed the stale label Feb 29, 2024
@Twixes Twixes force-pushed the scene-snapshots-noclip branch from e40c9ba to 685e72f Compare March 11, 2024 13:25
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@Twixes Twixes removed the stale label Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from github-actions bot Mar 11, 2024
@Twixes Twixes force-pushed the scene-snapshots-noclip branch 2 times, most recently from be0ac72 to 09b101e Compare March 11, 2024 16:45
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@Twixes Twixes force-pushed the scene-snapshots-noclip branch 2 times, most recently from d474215 to 1e563ca Compare March 11, 2024 17:34
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@PostHog PostHog deleted a comment from posthog-bot Mar 11, 2024
@Twixes Twixes force-pushed the scene-snapshots-noclip branch from d9a1f52 to eb9d948 Compare March 11, 2024 18:28
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes force-pushed the scene-snapshots-noclip branch from 89f6175 to f32ddc4 Compare March 15, 2024 21:17
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes force-pushed the scene-snapshots-noclip branch from ac44e5c to 23bdc9b Compare March 15, 2024 22:11
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes force-pushed the scene-snapshots-noclip branch from 7ca6764 to a62df46 Compare March 15, 2024 22:35
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes force-pushed the scene-snapshots-noclip branch from 39a542c to 4b45bb7 Compare March 16, 2024 00:05
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes merged commit 66eb25d into master Mar 18, 2024
80 checks passed
@Twixes Twixes deleted the scene-snapshots-noclip branch March 18, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thmsobrmlr thmsobrmlr thmsobrmlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Twixes @posthog-bot @thmsobrmlr