chore: Upgrade pydantic, mypy, and others #19660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -2.65 kB (0%) Total Size: 2 MB
|
|
@pauldambra I saw that you tried to update mypy before. I need to update it here, because updating pydantic and others breaks it (as noted above). I found mypy-baseline as a tool to work around the issue that the update causes 1229 problems 😅 |
webjunkie
changed the title
|
@webjunkie nice! That seems like a good trade-off... we're effectively ignoring those errors by not upgrading mypy... I like that the tool prompts you on progress too so it's that little bit harder to forget 😊 |
pauldambra
reviewed
Jan 9, 2024
| @@ -157,141 +158,5 @@ | |||
| prop | |||
| HAVING steps = max_steps) | |||
| GROUP BY prop | |||
| ' | |||
| --- | |||
| # name: ClickhouseTestExperimentSecondaryResults.test_basic_secondary_metric_results.5 | |||
There was a problem hiding this comment.
i think this is normally snapshots that no longer exist...
pauldambra
approved these changes
Jan 9, 2024
| @@ -286,124 +173,10 @@ | |||
| prop | |||
| HAVING steps = max_steps) | |||
| GROUP BY prop | |||
| ' | |||
| --- | |||
| # name: ClickhouseTestFunnelExperimentResults.test_experiment_flow_with_event_results_and_events_out_of_time_range_timezones.2 | |||
| @@ -279,88 +280,10 @@ | |||
| AND NOT "posthog_annotation"."deleted") | |||
| ORDER BY "posthog_annotation"."date_marker" DESC | |||
| LIMIT 1000 /*controller='project_annotations-list',route='api/projects/%28%3FP%3Cparent_lookup_team_id%3E%5B%5E/.%5D%2B%29/annotations/%3F%24'*/ | |||
| ' | |||
| --- | |||
| # name: TestAnnotation.test_retrieving_annotation_is_not_n_plus_1.15 | |||
| @@ -1538,28 +1539,10 @@ | |||
| WHERE (NOT ("posthog_dashboard"."deleted") | |||
| AND "posthog_dashboard"."id" = 2) | |||
| LIMIT 21 /*controller='project_insights-list',route='api/projects/%28%3FP%3Cparent_lookup_team_id%3E%5B%5E/.%5D%2B%29/insights/%3F%24'*/ | |||
| ' | |||
| --- | |||
| # name: TestInsight.test_listing_insights_does_not_nplus1.30 | |||
| SELECT "posthog_instancesetting"."id", | ||
| "posthog_instancesetting"."key", | ||
| "posthog_instancesetting"."raw_value" | ||
| FROM "posthog_instancesetting" | ||
| WHERE "posthog_instancesetting"."key" = 'constance:posthog:PERSON_ON_EVENTS_ENABLED' | ||
| ORDER BY "posthog_instancesetting"."id" ASC | ||
| LIMIT 1 /*controller='project_dashboards-detail',route='api/projects/%28%3FP%3Cparent_lookup_team_id%3E%5B%5E/.%5D%2B%29/dashboards/%28%3FP%3Cpk%3E%5B%5E/.%5D%2B%29/%3F%24'*/ | ||
| ' | ||
| --- | ||
| # name: TestDashboard.test_loading_individual_dashboard_does_not_prefetch_all_possible_tiles.315 |
| @@ -364,66 +357,21 @@ | |||
| FROM "posthog_organizationmembership" | |||
| INNER JOIN "posthog_organization" ON ("posthog_organizationmembership"."organization_id" = "posthog_organization"."id") | |||
| WHERE "posthog_organizationmembership"."user_id" = 2 /*controller='project_notebooks-list',route='api/projects/%28%3FP%3Cparent_lookup_team_id%3E%5B%5E/.%5D%2B%29/notebooks/%3F%24'*/ | |||
| ' | |||
| --- | |||
| # name: TestNotebooks.test_updates_notebook.20 | |||
jacobwgillespie
pushed a commit
to jacobwgillespie/posthog
that referenced
this pull request
Jan 12, 2024
* Upgrade pydantic and all related
* Upgrade mypy
* Add mypy-baseline
To update baseline when you fix something (only then!) use:
[mypy cmd] | mypy-baseline sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Upgrading pydantic and drf-spectacular so they work together.
Preparing for other PRs, i.e. #19408
Changes
see https://github.com/tfranzel/drf-spectacular/releases/tag/0.27.0
AssertionError: Internal error: too many class plugin hook passes python/mypy#15004
How did you test this code?