feat(trends): use the bespoke other and null value in trends breakdowns #19620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilbert09
changed the title
|
Hey @Gilbert09! 👋 |
Gilbert09
commented
Jan 5, 2024
| @@ -4745,7 +4753,7 @@ def test_breakdown_filtering(self): | |||
| self.team, | |||
| ) | |||
|
|
|||
| self.assertEqual(response[0]["label"], "sign up - none") | |||
| self.assertEqual(response[0]["label"], "sign up - $$_posthog_breakdown_other_$$") | |||
| self.assertEqual(response[1]["label"], "sign up - value") | |||
| self.assertEqual(response[2]["label"], "sign up - other_value") | |||
| self.assertEqual(response[3]["label"], "no events - none") | |||
There was a problem hiding this comment.
This has to stay as none. Because there's no events, there are no breakdown values, and therefore we don't know the type of the values, therefore we dont know which version of the "other" value to use. Using the wrong one causes a clickhouse error with mismatched types with no supertype
mariusandra
approved these changes
Jan 5, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
jacobwgillespie
pushed a commit
to jacobwgillespie/posthog
that referenced
this pull request
Jan 12, 2024
…ns (PostHog#19620) * Use the bespoke other and null value in trends breakdowns * Fixed tests * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Nonein the code, allowing for theOtherbreakdown to work as expected with strings, ints, and floatsHow did you test this code?