-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Open-source hobby deploy fails, fix PostHog/posthog#16169 #19613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
environment: | ||
TEMPORAL_HOST: temporal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep this here as it may be used somewhere else. Hobby docker compose should be overwriting this entire block anyways, so keeping it won't hurt there.
SENTRY_DSN: $SENTRY_DSN | ||
SITE_URL: https://$DOMAIN | ||
TEMPORAL_HOST: temporal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading through the issue, we may need SECRET_KEY: $POSTHOG_SECRET
here too. Have you been able to verify this @jk2K? If not, I can run a test of the hobby stack later today and decide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, got error.
ValueError: Duplicated timeseries in CollectorRegistry: {'posthog_celery_task_pre_run_created', 'posthog_celery_task_pre_run_total', 'posthog_celery_task_pre_run'}
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
@tomasfarias thanks for updating the hobby deployment your suggestion of adding
I also added:
but I'm not certain they are required. Based on experience trying to fix some other issues when upgrading the hobby deployment to Would be really valuable to get these in – currently hobby deployments don't seem to run correctly without this? |
fix #16169
expected