feat(trends): Added smoothing to new trends query runner #19578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Gilbert09! 👋 |
Gilbert09
changed the title
Twixes
reviewed
Jan 5, 2024
| and self.query.trendsFilter.smoothing_intervals is not None | ||
| and self.query.trendsFilter.smoothing_intervals > 1 | ||
| ): | ||
| smoothing_count = ast.Alias( |
There was a problem hiding this comment.
I would love if we switched the vague "smoothing" terminology to "rolling average". This was a UI issue we saw with some of the users we opted into this beta feature. In the code this is not so much as UX issue, but still worth having a single accurate name (except smoothing_intervals I guess, since that's an existing schema)
There was a problem hiding this comment.
Nice yeah, have updated this
jacobwgillespie
pushed a commit
to jacobwgillespie/posthog
that referenced
this pull request
Jan 12, 2024
* Added smoothing to new trends query runner * Update query snapshots * Update query snapshots * Fixed tests * Update query snapshots * Updated the name to rolling average * Fixed snaoshots * Update query snapshots --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?