feat: incremental updates for mobile transformer #19567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
|
More like a question, since we have synthetic IDs, what if the removed/updated wireframe is a synthetic ID? Would that work the way how it is implemented? I believe the synthetic IDs are just the nested components right? For example, a |
marandaneto
approved these changes
Jan 3, 2024
daibhin
approved these changes
Jan 3, 2024
| if (convertedEl !== null) { | ||
| acc.push(convertedEl) | ||
| } | ||
| return acc | ||
| }, [] as serializedNodeWithId[]) | ||
| } | ||
|
|
||
| function isMobileIncrementalSnapshotEvent(x: unknown): x is MobileIncrementalSnapshotEvent { |
There was a problem hiding this comment.
Feels like this does a little more than just checking the type on the event
Suggested change
| function isMobileIncrementalSnapshotEvent(x: unknown): x is MobileIncrementalSnapshotEvent { | |
| function isValidMobileIncrementalSnapshotEvent(x: unknown): x is MobileIncrementalSnapshotEvent { |
There was a problem hiding this comment.
hmmm, I want to split this up more so I'm going to punt this into the future
19 tasks
fuziontech
pushed a commit
that referenced
this pull request
Jan 4, 2024
first pass at adding incremental mutations created some fake mobile recordings locally and these behaved as expected this adds: removals these can be passed through - they're the same as rrweb adds the added wireframes can be converted just like in full snapshots (I think) updates these are implemented as removes and then adds this might not work on recordings with very many mutations but it'll be at least enough for us to get some folk testing it and we should have few enough mutations that it'll be ok
fuziontech
added a commit
that referenced
this pull request
Jan 4, 2024
* master: (94 commits) feat: Add cta on billing for >20k annual spend customers (#19508) refactor(temporal/squash): Support flat person override table in squash workflow (#19347) fix(surveys): remove link in user interview template (#19584) feat: populate plugin capabilities on install and edit (#19188) chore: Make plugin-server ignore deleted plugin configs (#18444) chore: Add Flutter feature flags snippets (#19563) fix(bi): fixed some of the query duplications (#19573) fix: assume typeless series nodes are of type events node (#19550) chore(deps): bump chromaui/action from 1 to 10 (#19560) fix(trends): fix breakdowns persons label (#19534) fix(trends): fix breakdown legend (#19533) feat: incremental updates for mobile transformer (#19567) chore(deps): bump peter-evans/find-comment from 1 to 2 (#19559) chore(data-warehouse): cleanup unused celery code and extend time (#19568) Revert "feat(data-warehouse): hubspot integration" (#19569) feat(data-warehouse): hubspot integration (#19529) feat: Feature gate session replay controls using available_product_features (#19401) fix: Padding on bullet lists (#19565) chore: Post 3000 LemonButtton cleanup (#19540) chore(deps): bump aws-actions/amazon-ecr-login from 1 to 2 (#19558) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first pass at adding incremental mutations
created some fake mobile recordings locally and these behaved as expected
this adds: