Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Flutter feature flags snippets #19563

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

marandaneto
Copy link
Member

Problem

Flutter supports isFeatureEnabled but its missing on the page.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@marandaneto marandaneto requested review from neilkakkar and a team January 2, 2024 16:21
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@marandaneto marandaneto marked this pull request as ready for review January 2, 2024 16:32
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about flutter so 🚢 😊

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/PostHog/posthog/actions/runs/7388141560/job/20116895118?pr=19563

looks like the Cypress test needs the assertion updating to match the new values

Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marandaneto marandaneto merged commit e28d34c into master Jan 3, 2024
78 checks passed
@marandaneto marandaneto deleted the chore/add-flutter-snippets branch January 3, 2024 12:19
fuziontech added a commit that referenced this pull request Jan 4, 2024
* master: (94 commits)
  feat: Add cta on billing for >20k annual spend customers (#19508)
  refactor(temporal/squash): Support flat person override table in squash workflow (#19347)
  fix(surveys): remove link in user interview template (#19584)
  feat: populate plugin capabilities on install and edit (#19188)
  chore: Make plugin-server ignore deleted plugin configs (#18444)
  chore: Add Flutter feature flags snippets (#19563)
  fix(bi): fixed some of the query duplications (#19573)
  fix: assume typeless series nodes are of type events node (#19550)
  chore(deps): bump chromaui/action from 1 to 10 (#19560)
  fix(trends): fix breakdowns persons label (#19534)
  fix(trends): fix breakdown legend (#19533)
  feat: incremental updates for mobile transformer (#19567)
  chore(deps): bump peter-evans/find-comment from 1 to 2 (#19559)
  chore(data-warehouse): cleanup unused celery code and extend time (#19568)
  Revert "feat(data-warehouse): hubspot integration" (#19569)
  feat(data-warehouse): hubspot integration (#19529)
  feat: Feature gate session replay controls using available_product_features (#19401)
  fix: Padding on bullet lists (#19565)
  chore: Post 3000 LemonButtton cleanup (#19540)
  chore(deps): bump aws-actions/amazon-ecr-login from 1 to 2 (#19558)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants