Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Gate exports by data pipelines feature availability #19561

Merged
merged 11 commits into from
Jan 16, 2024

Conversation

tiina303
Copy link
Contributor

@tiina303 tiina303 commented Jan 2, 2024

Problem

For ability to unsubscribe from data exports we'll need to limit the old UI access
https://posthog.slack.com/archives/C0374DA782U/p1702644859275309

IMPORTANT: the available feature needs to be set-up first on billing to not block everyone's access.

Note: that the apps table now can have small empty rows for apps we're hiding, but it's the old UI ... so don't want to spend too much time making it pretty.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@tiina303 tiina303 requested a review from raquelmsmith January 2, 2024 14:45
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Size Change: +23 B (0%)

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 2 MB +23 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@tiina303 tiina303 marked this pull request as ready for review January 3, 2024 16:51
@tiina303 tiina303 requested review from Twixes and a team January 3, 2024 16:54
Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this locally, I assume you did. I think this is fine for now, but for the new UI I think we should definitely show some sort of feature gate (eg "upgrade now to get access to this app") instead of showing nothing at all.

@raquelmsmith
Copy link
Member

Oh and this should def wait to be merged until everyone is on the correct plans. I will manage merging this.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@raquelmsmith
Copy link
Member

If they aren't subscribed they will still see the Batch Exports tab, but they'll get a paygate:
image

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@raquelmsmith raquelmsmith enabled auto-merge (squash) January 16, 2024 16:18
@raquelmsmith raquelmsmith merged commit 9baf0b8 into master Jan 16, 2024
98 checks passed
@raquelmsmith raquelmsmith deleted the gate-exports-for-data-pipelines branch January 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants