-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Gate exports by data pipelines feature availability #19561
Conversation
Size Change: +23 B (0%) Total Size: 2 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this locally, I assume you did. I think this is fine for now, but for the new UI I think we should definitely show some sort of feature gate (eg "upgrade now to get access to this app") instead of showing nothing at all.
Oh and this should def wait to be merged until everyone is on the correct plans. I will manage merging this. |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
Problem
For ability to unsubscribe from data exports we'll need to limit the old UI access
https://posthog.slack.com/archives/C0374DA782U/p1702644859275309
IMPORTANT: the available feature needs to be set-up first on billing to not block everyone's access.
Note: that the apps table now can have small empty rows for apps we're hiding, but it's the old UI ... so don't want to spend too much time making it pretty.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?