Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set mock date for pipeline stories #19547

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

pauldambra
Copy link
Member

spotted these screenshots flap in another PR because time had passed....

e321d56

this should fix the date in the test so that they don't any more

@pauldambra pauldambra requested review from tiina303 and a team January 2, 2024 12:08
Copy link
Contributor

@tiina303 tiina303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@pauldambra pauldambra enabled auto-merge (squash) January 2, 2024 13:05
@pauldambra pauldambra merged commit b844f21 into master Jan 2, 2024
78 checks passed
@pauldambra pauldambra deleted the fix/mock-date-for-pipeline-stories branch January 2, 2024 13:11
@tiina303
Copy link
Contributor

tiina303 commented Jan 2, 2024

@pauldambra Do you want to add it to https://storybook.posthog.net/?path=/docs/how-to-build-a-scene--docs#6-create-a-story-for-your-scene and https://storybook.posthog.net/?path=/docs/how-to-create-stories--docs so future story creators won't forget to add a mockDate if necessary 🤷

fuziontech pushed a commit that referenced this pull request Jan 4, 2024
* fix: set mock date for pipeline stories

* Update UI snapshots for `chromium` (1)

* slightly nicer mock date

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants