Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all input number #19545

Merged
merged 8 commits into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ module.exports = {
element: 'Badge',
message: 'use LemonBadge instead',
},
{
element: 'InputNumber',
message: 'use LemonInput with type="number" instead',
},
{
element: 'Collapse',
message: 'use <LemonCollapse> instead',
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/surveys.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe('Surveys', () => {
cy.get('[data-attr=prop-val] .ant-select-selector').click({ force: true })
cy.get('[data-attr=prop-val-0]').click({ force: true })

cy.get('.ant-input-number-input-wrap>input').type('{backspace}')
cy.get('[data-attr="rollout-percentage"]').type('{backspace}')

// save
cy.get('[data-attr="save-survey"]').click()
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/scenes/experiments/ExperimentPreview.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { LemonButton, LemonDivider, LemonModal, Tooltip } from '@posthog/lemon-ui'
import { InputNumber, Slider } from 'antd'
import { LemonButton, LemonDivider, LemonInput, LemonModal, Tooltip } from '@posthog/lemon-ui'
import { Slider } from 'antd'
import { useActions, useValues } from 'kea'
import { Field, Form } from 'kea-forms'
import { InsightLabel } from 'lib/components/InsightLabel'
Expand Down Expand Up @@ -136,12 +136,12 @@ export function ExperimentPreview({
tipFormatter={(value) => `${value}%`}
/>
</div>
<InputNumber
<LemonInput
type="number"
min={1}
max={sliderMaxValue}
defaultValue={5}
formatter={(value) => `${value}%`}
style={{ margin: '0 16px' }}
suffix={<span>%</span>}
value={minimumDetectableChange}
onChange={(value) => {
setExperiment({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import './FeatureFlag.scss'

import { LemonSelect, Link } from '@posthog/lemon-ui'
import { InputNumber, Select } from 'antd'
import { LemonInput, LemonSelect, Link } from '@posthog/lemon-ui'
import { Select } from 'antd'
import { useActions, useValues } from 'kea'
import { router } from 'kea-router'
import { allOperatorsToHumanName } from 'lib/components/DefinitionPopover/utils'
Expand Down Expand Up @@ -242,15 +242,17 @@ export function FeatureFlagReleaseConditions({
<div className="feature-flag-form-row gap-2">
<div className="flex items-center gap-1">
Roll out to{' '}
<InputNumber
style={{ width: 100, marginLeft: 8, marginRight: 8 }}
<LemonInput
data-attr="rollout-percentage"
type="number"
className="mx-2"
onChange={(value): void => {
updateConditionSet(index, value)
updateConditionSet(index, value || 100)
}}
value={group.rollout_percentage != null ? group.rollout_percentage : 100}
min={0}
max={100}
addonAfter="%"
suffix={<span>%</span>}
/>{' '}
of <b>{aggregationTargetName}</b> in this set.{' '}
</div>
Expand Down
12 changes: 7 additions & 5 deletions frontend/src/scenes/insights/EditorFilters/PathsAdvanced.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { LemonDivider } from '@posthog/lemon-ui'
import { InputNumber } from 'antd'
import { LemonDivider, LemonInput } from '@posthog/lemon-ui'
import { useActions, useValues } from 'kea'
import { PayGateMini } from 'lib/components/PayGateMini/PayGateMini'
import { IconSettings } from 'lib/lemon-ui/icons'
Expand Down Expand Up @@ -42,7 +41,8 @@ export function PathsAdvanced({ insightProps, ...rest }: EditorFilterProps): JSX
<LemonLabel info="Determines the maximum number of path nodes that can be generated. If necessary certain items will be grouped.">
Maximum number of paths
</LemonLabel>
<InputNumber
<LemonInput
type="number"
min={0}
max={1000}
defaultValue={50}
Expand All @@ -63,7 +63,8 @@ export function PathsAdvanced({ insightProps, ...rest }: EditorFilterProps): JSX
</LemonLabel>
<div>
<span className="mr-2">Between</span>
<InputNumber
<LemonInput
type="number"
min={0}
max={100000}
onChange={(value): void =>
Expand All @@ -76,7 +77,8 @@ export function PathsAdvanced({ insightProps, ...rest }: EditorFilterProps): JSX
onPressEnter={updateEdgeParameters}
/>
<span className="mx-2">and</span>
<InputNumber
<LemonInput
type="number"
onChange={(value): void =>
setLocalEdgeParameters((state) => ({
...state,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { InputNumber, Select } from 'antd'
import { LemonInput } from '@posthog/lemon-ui'
import { Select } from 'antd'
import clsx from 'clsx'
import { useActions, useValues } from 'kea'
import { BIN_COUNT_AUTO } from 'lib/constants'
Expand Down Expand Up @@ -63,9 +64,9 @@ export function FunnelBinsPicker({ disabled }: FunnelBinsPickerProps): JSX.Eleme
<>
{menu}
<div>
<InputNumber
<LemonInput
type="number"
className="funnel-bins-custom-picker"
size="middle"
min={MIN}
max={MAX}
value={numericBinCount}
Expand Down
Loading