Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(3000): remove activation sidebar #19542

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Dec 28, 2023

Problem

Follow up to #19535

Changes

This PR removes the activation sidebar, page button and sidebar change notice tooltip.

How did you test this code?

CI run & created new project where I completed the activation flow

Copy link
Contributor

github-actions bot commented Dec 28, 2023

Size Change: -619 B (0%)

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 2 MB -619 B (0%)

compressed-size-action

@thmsobrmlr thmsobrmlr mentioned this pull request Dec 28, 2023
3 tasks
Base automatically changed from remove-sidebar to master January 9, 2024 10:52
@PostHog PostHog deleted a comment from posthog-bot Jan 9, 2024
@thmsobrmlr thmsobrmlr removed the stale label Jan 9, 2024
@thmsobrmlr thmsobrmlr force-pushed the remove-activation-sidebar branch from 1673e9f to 93eb0cf Compare January 9, 2024 14:28
@thmsobrmlr thmsobrmlr requested review from a team and raquelmsmith January 9, 2024 15:54
Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the old one, ya? The new one in the side panel still exists? (I assume so, just double checking)

@thmsobrmlr
Copy link
Contributor Author

This is just the old one, ya? The new one in the side panel still exists? (I assume so, just double checking)

Yep, right. Tagged you in case something goes wrong, so you know whom to ping.

@thmsobrmlr thmsobrmlr merged commit d36e7ad into master Jan 10, 2024
99 checks passed
@thmsobrmlr thmsobrmlr deleted the remove-activation-sidebar branch January 10, 2024 08:37
jacobwgillespie pushed a commit to jacobwgillespie/posthog that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants