Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3000): re-implement debug notice #19538

Merged
merged 6 commits into from
Jan 9, 2024
Merged

fix(3000): re-implement debug notice #19538

merged 6 commits into from
Jan 9, 2024

Conversation

thmsobrmlr
Copy link
Contributor

Problem

The debug notice was missing after 3000.

Changes

This PR adds the debug notice to the minimal sidebar in collapsed and expanded mode:

Screenshot 2023-12-28 at 17 09 43 Screenshot 2023-12-28 at 17 09 54

How did you test this code?

👀

@thmsobrmlr thmsobrmlr mentioned this pull request Dec 28, 2023
3 tasks
Copy link
Contributor

github-actions bot commented Dec 28, 2023

Size Change: +76 B (0%)

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 2 MB +76 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

  • chromium: 0 added, 6 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@thmsobrmlr thmsobrmlr requested a review from a team December 28, 2023 22:51
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes force-pushed the remove-debug-notice branch from 637c8d2 to f264d59 Compare January 5, 2024 17:41
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Has been a FIXME in Navigation.tsx for a while. With this new notice, I removed that leftover FIXME.

I also made a few styling tweaks, which make the notice a bit more compact, and more similar to the non-navigation notice from the HTML template. Let me know if it looks alright, or if using colors from the logo is a bit much 😄

Before After
Screenshot 2024-01-05 at 18 23 24 Screenshot 2024-01-05 at 18 21 10

Base automatically changed from remove-sidebar to master January 9, 2024 10:52
@thmsobrmlr thmsobrmlr force-pushed the remove-debug-notice branch from f264d59 to 8403a14 Compare January 9, 2024 10:58
@thmsobrmlr
Copy link
Contributor Author

Thanks for picking this up! Has been a FIXME in Navigation.tsx for a while. With this new notice, I removed that leftover FIXME.

I also made a few styling tweaks, which make the notice a bit more compact, and more similar to the non-navigation notice from the HTML template. Let me know if it looks alright, or if using colors from the logo is a bit much 😄

Before After
Screenshot 2024-01-05 at 18 23 24 Screenshot 2024-01-05 at 18 21 10

This looks great, thanks!

@thmsobrmlr thmsobrmlr enabled auto-merge (squash) January 9, 2024 11:09
@thmsobrmlr thmsobrmlr merged commit dbcbf38 into master Jan 9, 2024
99 checks passed
@thmsobrmlr thmsobrmlr deleted the remove-debug-notice branch January 9, 2024 11:46
jacobwgillespie pushed a commit to jacobwgillespie/posthog that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants