-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(3000): re-implement debug notice #19538
Conversation
Size Change: +76 B (0%) Total Size: 2 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
637c8d2
to
f264d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up! Has been a FIXME in Navigation.tsx for a while. With this new notice, I removed that leftover FIXME.
I also made a few styling tweaks, which make the notice a bit more compact, and more similar to the non-navigation notice from the HTML template. Let me know if it looks alright, or if using colors from the logo is a bit much 😄
Before | After |
---|---|
f264d59
to
8403a14
Compare
This looks great, thanks! |
--------- Co-authored-by: Michael Matloka <[email protected]>
Problem
The debug notice was missing after 3000.
Changes
This PR adds the debug notice to the minimal sidebar in collapsed and expanded mode:
How did you test this code?
👀