chore(3000): remove notebook popover #19537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
changed the title
3 tasks
thmsobrmlr
force-pushed
the
remove-notebook-popover
branch
from
9b64b83 to
9c7cd74
Compare
|
Size Change: -2.4 kB (0%) Total Size: 2 MB
|
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
daibhin
approved these changes
Dec 29, 2023
frontend/src/scenes/notebooks/NotebookPanel/notebookPopoverLogic.ts
Outdated
Show resolved
Hide resolved
frontend/src/scenes/notebooks/NotebookPanel/notebookPopoverLogic.ts
Outdated
Show resolved
Hide resolved
frontend/src/scenes/notebooks/NotebookPanel/notebookPopoverLogic.ts
Outdated
Show resolved
Hide resolved
thmsobrmlr
force-pushed
the
remove-notebook-popover
branch
from
a226c5b to
0b5d881
Compare
📸 UI snapshots have been updated7 snapshot changes in total. 0 added, 7 modified, 0 deleted:
Triggered by this commit. |
jacobwgillespie
pushed a commit
to jacobwgillespie/posthog
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up to #19535.
Changes
This PR removes the notebook popover.
I think the
notebookPopoverLogicshould be fully merged intonotebookPanelLogic, but was a bit unsure of the changes / what the remaining code does, especiallyurlToAction. Let me know wether I can just move over the code or there is more to it (e.g. the logic being mounted only in certain places and that's why we listen for/*).How did you test this code?
Re-built the app and CI run