Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(product-analytics): Hide filtering by dashboard if there are none #19530

Merged
merged 6 commits into from
Jan 9, 2024
Merged

fix(product-analytics): Hide filtering by dashboard if there are none #19530

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
378deec
Add conditional rendering based on the length of the sorted dashboard…
baristaGeek Dec 27, 2023
bc14827
Add conditional rendering to dashboard selection
baristaGeek Dec 27, 2023
4883534
Only hide the dashboards filter
baristaGeek Jan 3, 2024
5c97bef
Merge branch 'master' into feature/product-analytics-hide-dashboard-d…
baristaGeek Jan 3, 2024
6824001
Merge branch 'master' into feature/product-analytics-hide-dashboard-d…
Twixes Jan 5, 2024
4a4eb62
Merge branch 'master' into feature/product-analytics-hide-dashboard-d…
Twixes Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 19 additions & 17 deletions frontend/src/scenes/saved-insights/SavedInsightsFilters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,25 @@ export function SavedInsightsFilters(): JSX.Element {
value={search || ''}
/>
<div className="flex items-center gap-2 flex-wrap">
<div className="flex items-center gap-2">
<span>On dashboard:</span>
<LemonSelect
size="small"
options={nameSortedDashboards.map((nsd) => ({
value: nsd.id,
label: nsd.name,
}))}
value={dashboardId}
onChange={(newValue) => {
setSavedInsightsFilters({ dashboardId: newValue })
}}
dropdownMatchSelectWidth={false}
data-attr="insight-on-dashboard"
allowClear={true}
/>
</div>
{nameSortedDashboards.length > 0 && (
<div className="flex items-center gap-2">
<span>On dashboard:</span>
<LemonSelect
size="small"
options={nameSortedDashboards.map((nsd) => ({
value: nsd.id,
label: nsd.name,
}))}
value={dashboardId}
onChange={(newValue) => {
setSavedInsightsFilters({ dashboardId: newValue })
}}
dropdownMatchSelectWidth={false}
data-attr="insight-on-dashboard"
allowClear={true}
/>
</div>
)}
<div className="flex items-center gap-2">
<span>Type:</span>
<LemonSelect
Expand Down
Loading