chore(3000): remove legacy notebooks icon #19523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
daibhin
reviewed
Dec 28, 2023
| import { useActions } from 'kea' | ||
| import { notebookPanelLogic } from 'scenes/notebooks/NotebookPanel/notebookPanelLogic' | ||
|
|
||
| export function NotebookButton(): JSX.Element { |
There was a problem hiding this comment.
Where does this component get referenced?
There was a problem hiding this comment.
Good catch! That's the result of a merge conflict and shouldn't be here.
daibhin
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're only using the notebook icon from
@posthog/iconsafter 3000.Changes
This PR remove legacy icon handling.
How did you test this code?
CI run