Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(process): load mock process in app #19522

Merged
merged 3 commits into from
Dec 27, 2023
Merged

fix(process): load mock process in app #19522

merged 3 commits into from
Dec 27, 2023

Conversation

thmsobrmlr
Copy link
Contributor

@thmsobrmlr thmsobrmlr commented Dec 27, 2023

Problem

We are setting window.process in frontend/src/layout/navigation/TopBar/Announcement.tsx. This file is not included in the build after the 3000 rollout/refactor.

Changes

Moves the setup of window.process to frontend/src/scenes/App.tsx.

How did you test this code?

Re-built & verified dashboards load again

Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nice catch! Explains why this started happening just now :) 👍

@thmsobrmlr thmsobrmlr enabled auto-merge (squash) December 27, 2023 11:19
Copy link
Contributor

github-actions bot commented Dec 27, 2023

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@thmsobrmlr thmsobrmlr merged commit 398b559 into master Dec 27, 2023
78 checks passed
@thmsobrmlr thmsobrmlr deleted the fix-process-2 branch December 27, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants