feat: Add cta on billing for >20k annual spend customers #19508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrdt
commented
Dec 22, 2023
xrdt
commented
Dec 22, 2023
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
IMO this doesn't need to be dismissable, it can just be a persistent "ad" |
|
Newer screenshot |
|
Re dismissability: Can hide the CTA once they've converted to an annual plan. |
|
Changed how it looks a bit:
There's kind of an awkward gap above the "Products" header but cory wants to redo this page anyway so I think it's fine. |
raquelmsmith
requested changes
Jan 3, 2024
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
* auto-dismiss on annual plan * remove unused hedgehog png * slight tweak to css for smaller screens
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
raquelmsmith
requested changes
Jan 3, 2024
frontend/__snapshots__/scenes-other-billing-v2--billing-v-2-with-discount--dark.png
Outdated
Show resolved
Hide resolved
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
raquelmsmith
approved these changes
Jan 3, 2024
fuziontech
pushed a commit
that referenced
this pull request
Jan 4, 2024
* add cta on billing for >20k annual spend customers * Update UI snapshots for `chromium` (1) * tweak the bullets, add dismissal logic, handle small screen sizes * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * give it a box, update wording, improve spacing * fix spacing so it lines up across the top properly * fix * Update UI snapshots for `chromium` (1) * address pr feedback * auto-dismiss on annual plan * remove unused hedgehog png * slight tweak to css for smaller screens * Update UI snapshots for `chromium` (1) * lint * Update UI snapshots for `chromium` (1) * fix dark mode * Update UI snapshots for `chromium` (1) --------- Co-authored-by: Bianca Yang <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Raquel Smith <[email protected]>
fuziontech
added a commit
that referenced
this pull request
Jan 4, 2024
* master: (94 commits) feat: Add cta on billing for >20k annual spend customers (#19508) refactor(temporal/squash): Support flat person override table in squash workflow (#19347) fix(surveys): remove link in user interview template (#19584) feat: populate plugin capabilities on install and edit (#19188) chore: Make plugin-server ignore deleted plugin configs (#18444) chore: Add Flutter feature flags snippets (#19563) fix(bi): fixed some of the query duplications (#19573) fix: assume typeless series nodes are of type events node (#19550) chore(deps): bump chromaui/action from 1 to 10 (#19560) fix(trends): fix breakdowns persons label (#19534) fix(trends): fix breakdown legend (#19533) feat: incremental updates for mobile transformer (#19567) chore(deps): bump peter-evans/find-comment from 1 to 2 (#19559) chore(data-warehouse): cleanup unused celery code and extend time (#19568) Revert "feat(data-warehouse): hubspot integration" (#19569) feat(data-warehouse): hubspot integration (#19529) feat: Feature gate session replay controls using available_product_features (#19401) fix: Padding on bullet lists (#19565) chore: Post 3000 LemonButtton cleanup (#19540) chore(deps): bump aws-actions/amazon-ecr-login from 1 to 2 (#19558) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Updates the existing >$1k monthly spend alert to include more perks we can offer to large customers.
Changes
No CTA:
With CTA:
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?