chore(DatePicker): fix date picker appearance #19497
Conversation
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
| // HACKY: replace 'Ok' with 'OK' | ||
| .ant-picker-ok .ant-btn-primary span { | ||
| font-size: 0; | ||
| visibility: hidden; | ||
| } |
There was a problem hiding this comment.
Possibly a less hacky way is text-transform: uppercase? But both hacks only work if we're sure that we don't override "Ok" with something else anywhere
There was a problem hiding this comment.
Oh right, that's rather obvious 🤦
|
|
||
| .posthog-3000[theme='dark'] { | ||
| .ant-picker-time-panel-column > li.ant-picker-time-panel-cell-selected .ant-picker-time-panel-cell-inner { | ||
| background: rgba(#f7a503, 0.4); |
There was a problem hiding this comment.
We want to avoid one-off colors, because they're really difficult to maintain. But all of these overrides will be deleted as soon as we add time picking support to LemonCalendarSelect, so I'll just try to get to that this week. We've been putting it off for quite a bit.
There was a problem hiding this comment.
Yep, I was aware you wanted to add this to the Lemon picker, great to hear it's coming soon :)
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Changes
Make DatePicker nicer on 3000.
How did you test this code?
👀