Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't use mat cols for session recordings events query #19491

Merged
merged 8 commits into from
Jan 4, 2024

Conversation

fuziontech
Copy link
Member

@fuziontech fuziontech commented Dec 21, 2023

Problem

If we miss the materialized column here we no longer see the bug when querying events table for session replay product

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might have an impact on API performance but only for a subset of queries... and not doing it is impacting the whole cluster so 🙃

@pauldambra pauldambra merged commit d16aab4 into master Jan 4, 2024
92 checks passed
@pauldambra pauldambra deleted the no_mat_col branch January 4, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants