fix: re2 dot all flag for non-hogql filters #19487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks right....let me tag an expert though @EDsCODE 👀 |
fuziontech
approved these changes
Dec 21, 2023
| elif operator == PropertyOperator.regex: | ||
| return ast.Call(name="match", args=[field, ast.Constant(value=value)]) | ||
| return ast.Call(name="match", args=[field, ast.Constant(value=f"(?-s){value}")]) |
There was a problem hiding this comment.
This definitely looks correct.
| # but in CH it seems to be true by default. | ||
| # prepending (?-s) to the regex string will make it work as expected | ||
| # see https://github.com/ClickHouse/ClickHouse/issues/34603 | ||
| "v{}_{}".format(prepend, idx): f"(?-s){prop.value}", |
|
@mariusandra for the HogQL assist too? |
EDsCODE
approved these changes
Dec 21, 2023
|
Closing this one up since we won't be landing it (it breaks regex elsewhere in the app) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we follow re2 regex syntax and so does ClickHouse except
For example, the string a\nb shouldn't match the pattern a.b, but it does in CH
this is because According to the re2 docs, the s flag is false by default,
but in CH it seems to be true by default.
prepending (?-s) to the regex string will make it work as expected
see ClickHouse/ClickHouse#34603
we found this while investigating queries hanging here https://posthog.slack.com/archives/C03PB072FMJ/p1703123107173919
We don't completely understand why this fixes it but in the reproduction case we had the query would hang forever (eventually killing the node) but not when prepending
(?-s)to the queryI think this patches regex for both non-HogQL property filters and HogQL queries
in our docs we explicitly say dot won't match newlines https://posthog.com/tutorials/regex-basics#the-basics-of-regex so it should be safe (or at least more correct) to change this behaviour for all filters