Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): dw heartbeat limits 2 #19486

Merged
merged 8 commits into from
Dec 26, 2023
Merged

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Dec 21, 2023

Problem

  • data imports can be arbitrarily long

Changes

  • use row limits to stop long running syncs

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @EDsCODE! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link
Contributor

github-actions bot commented Dec 21, 2023

Size Change: +1.61 kB (0%)

Total Size: 2 MB

Filename Size Change
frontend/dist/toolbar.js 2 MB +1.61 kB (0%)

compressed-size-action

@EDsCODE EDsCODE merged commit 15c2f8a into master Dec 26, 2023
78 checks passed
@EDsCODE EDsCODE deleted the dw-heartbeat-limits-2 branch December 26, 2023 15:56
Copy link

sentry-io bot commented Dec 27, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ PipelineStepFailed: Pipeline execution failed at stage extract when processing package 1703709177.4925663 with except... dlt.pipeline.pipeline in extract View Issue
  • ‼️ PipelineStepFailed: Pipeline execution failed at stage extract when processing package 1704298166.7186902 with except... dlt.pipeline.pipeline in extract View Issue

Did you find this useful? React with a 👍 or 👎

fuziontech pushed a commit that referenced this pull request Jan 4, 2024
* progress

* test

* add pause and unpause logic

* typing

* typing

* typing

* tested

* add log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants