Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trends): fix "other" misalignment #19484

Merged
merged 13 commits into from
Dec 22, 2023
Merged

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Dec 21, 2023

Problem

The "Other" value was not properly included in a CROSS JOIN in the trends query, causing it to skip columns with no data in the response. This misalignment shifted the rest of the data when "other" was the first returned column.

Changes

Include "Other" in the breakdown values array.

How did you test this code?

Locally in the browser. Updated tests that included bad data.

Before:

Screenshot 2023-12-21 at 16 30 22

After:

Screenshot 2023-12-21 at 16 30 40

@mariusandra mariusandra requested a review from a team December 21, 2023 15:50
@mariusandra mariusandra merged commit 2944c06 into master Dec 22, 2023
71 checks passed
@mariusandra mariusandra deleted the fix-other-misalignment branch December 22, 2023 08:36
Copy link

sentry-io bot commented Dec 22, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ CHQueryErrorQueryWasCancelled: Code: 394. /api/projects/{parent_lookup_team_id}/insights/... View Issue
  • ‼️ CHQueryErrorQueryWasCancelled: Code: 394. /api/projects/{parent_lookup_team_id}/insights/... View Issue
  • ‼️ CHQueryErrorQueryWasCancelled: Code: 394. /api/projects/{parent_lookup_team_id}/insights/... View Issue
  • ‼️ CHQueryErrorTimeoutExceeded: Code: 159. /api/projects/{parent_lookup_team_id}/insights/... View Issue
  • ‼️ **CHQueryErrorIllegalTypeOfArgument: Illegal type (Nullable(String)) of 1 argument of function and: While processing nullIf(nullIf(ma...** /api/projects/{parent_lookup_team_id}/insights/...` View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants