Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove antd from plugins #19481

Merged
merged 1 commit into from
Dec 21, 2023
Merged

chore: remove antd from plugins #19481

merged 1 commit into from
Dec 21, 2023

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Dec 21, 2023

Problem

We are still using antd in some obscure places

Changes

  • Stop using Button so that it is not picked up by linter warnings
  • Replace antd with equivalent Lemon styles

How did you test this code?

Before After
Screenshot 2023-12-21 at 14 37 03 Screenshot 2023-12-21 at 14 37 38
Before After
Screenshot 2023-12-21 at 14 17 16 Screenshot 2023-12-21 at 14 18 02
Before After
Screenshot 2023-12-21 at 14 24 54 Screenshot 2023-12-21 at 14 26 01
Before After
Screenshot 2023-12-21 at 14 32 04 Screenshot 2023-12-21 at 14 34 39

@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2 MB

compressed-size-action

@daibhin daibhin merged commit b1e3699 into master Dec 21, 2023
79 checks passed
@daibhin daibhin deleted the dn-chore/remove-more-antd branch December 21, 2023 16:33
fuziontech pushed a commit that referenced this pull request Jan 4, 2024
@daibhin @fuziontech
chore: remove antd from plugins (#19481)
35a18be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daibhin @benjackwhite