fix(tooltips): fix tooltips on dashboards #19473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 2 MB ℹ️ View Unchanged
|
mariusandra
approved these changes
Dec 21, 2023
thmsobrmlr
added a commit
that referenced
this pull request
Dec 21, 2023
fuziontech
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#19381 the tooltip isn't displayed when scrolling beyond the screen height.
Changes
This PR reverts #17906, which fixes the issue mentioned above. We all (@robbie-c , @benjackwhite and me haven't been able to reproduce the orginal issue any more. I think it might have been fixed with the React 18 upgrade and moving parts from layoutEffect to effect 6070407#diff-4e9ee68aa367eb18f567f0152f03571e91b57fb6a8d614644b4ad5669a735e52.
How did you test this code?
Tested on a shared dashboard